fix: escape double quotes and line breaks on CSharp generation of default value of properties#6473
Merged
baywet merged 5 commits intomicrosoft:mainfrom May 13, 2025
Conversation
…ault values properties
baywet
requested changes
Apr 17, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you also add a changelog entry please? (unreleased, changed)
Also, can you please sign the CLA (see the bots comment)
baywet
reviewed
Apr 17, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Ubisoft" |
0e45ac2 to
92562b8
Compare
baywet
approved these changes
May 13, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
samwelkanda
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix that escapes double quotes and line breaks from strings given.
fixes #6472
It is a bit of a hack since it seems like the parsing of properties at that point is already "unescaped" the values of the OpenApi document. This fix re-escapes the string that was unescaped, but only for characters that are invalid within a CSharp string.
Ideally there should be no need to re-escaping the string, since it seems like the OpenApiDocument object itself contains all the information.
Meanwhile the
CodeClass.Propertieshas escaped everything: