Add switch to skip workspace management for plugin generation#6464
Merged
Add switch to skip workspace management for plugin generation#6464
Conversation
baywet
previously requested changes
Apr 15, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
In addition to the comments, can you please:
- add a changelog entry
- add integration tests that the workspace DOES NOT get written upon add command when the setting is set to avoid any future regression
Contributor
Author
currently, there are no integration tests in Kiota.Builder for plugin generation, I suggests to create and additional issue to deal with this and other scenarios in a more holistic way for greater productivity and coverage |
baywet
reviewed
Apr 15, 2025
thewahome
previously approved these changes
Apr 22, 2025
Contributor
|
Can we update the spec to add the --no-workspace there? https://github.com/microsoft/kiota/blob/main/specs/cli/client-add.md |
Contributor
Author
Done, the change is only available for now for plugin, I have updated https://github.com/microsoft/kiota/blob/main/specs/cli/plugin-add.md |
petrhollayms
approved these changes
Apr 23, 2025
thewahome
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a switch to skip the workspace folder (.kiota) when generating a plugin.
See #6452
The CLI
addsubcommand for plugin generation adds a --no-workspace flagThe npm package adds a noWorkspace parameter