Allow schemas with additionalProperties to generate AdditionalData prop#6454
Merged
baywet merged 5 commits intomicrosoft:mainfrom May 13, 2025
Merged
Allow schemas with additionalProperties to generate AdditionalData prop#6454baywet merged 5 commits intomicrosoft:mainfrom
baywet merged 5 commits intomicrosoft:mainfrom
Conversation
…llowed or AdditionalProperties from the schema in KiotaBuilder
baywet
requested changes
Apr 14, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you also add an entry to the changelog please? (unreleased, changed)
baywet
approved these changes
May 13, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Thank you for your patience.
samwelkanda
approved these changes
May 13, 2025
MIchaelMainer
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating from a schema with
additionalPropertiesset to a schema instead oftrue, noAdditionalDataproperty is generated (only using theOpenApiSchemamodel because reading it from serialized format theAdditionalPropertiesAllowedistrueby default).This PR addresses parts of this comment, asking for this fix.
However it doesn't address the whole Issue yet. The type of the
AdditionalDataproperty should use the proper type indicated in theadditionalProperties, but that needs to be discussed further on whether that could break client's code.fixes #6443