Dart: fix wrong property name casing for serialization#6393
Merged
baywet merged 4 commits intomicrosoft:mainfrom Apr 4, 2025
Merged
Conversation
rkodev
previously approved these changes
Apr 4, 2025
867ed88 to
48d2a16
Compare
baywet
requested changes
Apr 4, 2025
baywet
approved these changes
Apr 4, 2025
rkodev
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the Dart refiner, where property names are adjusted for code style, but their serialized name is also changed by accident.
Example spec
In the example above, a body serialized by kiota would send it like:
{"token":"foo","type":"bar"}whereas the expected body is:
{"Token":"foo","type":"bar"}(notice the capitalized
Token, like it is in the spec)This PR fixes the refiner by storing the serialized name before changing the property name.