major reliability fixes and OData conventions cleanup#573
Merged
Conversation
bace49d to
aa4288b
Compare
3 tasks
3 tasks
7a1e5fd to
cd7e6b5
Compare
cfe7277 to
d050dc0
Compare
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes a bug where class namespace names odata functions would contain parenthesis Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
… imports Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…ns because of empty schema nodes Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes shortest namespace determination - major performance improvement in shortest namespace determination Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…ated Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
andrueastman
reviewed
Oct 1, 2021
andrueastman
reviewed
Oct 1, 2021
2880339 to
c96eac4
Compare
c96eac4 to
af27ff2
Compare
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
andrueastman
reviewed
Oct 4, 2021
Contributor
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Oct 4, 2021
Contributor
andrueastman
left a comment
There was a problem hiding this comment.
Thanks for all this!
Member
Author
|
Thanks a lot for the hard review work! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was started as a fix around unhandled path parameters cases (odata functions, etc...) and ended up being a major quality and performance PR. For a list of all the things it addresses, please check the changelog in the PR.
fixes #527. #623
Generation Diff
microsoft/kiota-samples#291