- adds support for raw URLs in request builders#508
Conversation
|
Todo doc comment new method request info |
3c2cf9e to
01ac5c1
Compare
618701e to
2cc60d1
Compare
aa4dfe6 to
aa415fa
Compare
Signed-off-by: GitHub <noreply@github.com>
aa415fa to
77198e0
Compare
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
|
Can you please give some examples of |
| if len(keyValue) == 2 { | ||
| request.QueryParameters[keyValue[0]] = keyValue[1] | ||
| } else if len(keyValue) == 1 { | ||
| request.QueryParameters[keyValue[0]] = "" |
There was a problem hiding this comment.
Is there value in adding the query parameter in the event that the value is absent/null? (I think this applies to all the languages)
There was a problem hiding this comment.
🤣 🤣 🤣
If we can, we should probably remember to upvote that answer
|
Kudos, SonarCloud Quality Gate passed! |
|
The generated code for the fluent API will generate That parameter is assigned to a property on the request builder which is then is passed to the This parameter is used in the setUri method to know whether we should:
Basically of of that is done to avoid appending a path segment when not needed and avoid "loosing" any query parameter that might already be present. |
|
I got the purpose of doing this. I asked for examples on how the code is used because: Can you please provide a code snippet when Please provide simple code snippets of the request builders with the new changes in the PR description as it gives more clarity. |
const page1 = await client.me.messages.get(); //raw url is false
const page2 = await (new MessagesRequestBuilder(page1.nextLink, httpCore)).get(); //is raw url is trueWould it be better if the description was changed to |
|
I would think of a different name instead of |
|
Suggestions are welcome but what do you think of "IsFullyQualifiedUrl"? |








fixes #410
Generation diff
microsoft/kiota-samples#225
Todo