Fixes duplicated Id suffix in indexers.#4547
Merged
andrueastman merged 1 commit intomainfrom Apr 25, 2024
Merged
Conversation
Closed
83bb45a to
3d0eb47
Compare
|
Id suffix in indexers.
baywet
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4519
This PR is a follow up to #4174 which deduplicates path parameters and adds the
-idsuffix to the indexers. However, in the event that the indexer ends up with theidsuffix without the-, downstream refiners will end up appending the two to result with duplicatedIdsuffix.This PR therefore adds an attempt to cleanup the
idsuffix before appending the-idsuffix so that an indexer likegroupIdwill now be changed togroup-idrather thangroupId-id.