Skip to content

- changes with by by for indexers replacements#2564

Merged
baywet merged 1 commit intomainfrom
feature/indexers-by
Apr 14, 2023
Merged

- changes with by by for indexers replacements#2564
baywet merged 1 commit intomainfrom
feature/indexers-by

Conversation

@baywet
Copy link
Member

@baywet baywet commented Apr 14, 2023

fixes #2528

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

Copy link
Member

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change. Is there a version bump missing? Do we need to update release notes with a mention of this change?

@baywet
Copy link
Member Author

baywet commented Apr 14, 2023

@MIchaelMainer thanks for keeping things in check. It's not a breaking change since:

  • Dotnet, the only stable language, uses indexers and doesn't have those compatibility methods (not impacted)
  • other languages are not stable yet and not covered by the support policy.
  • this was already "By" until we decided to change it last week to align with "with" at other places, and revisited that decision yesterday with all PMs (no public release yet).

@baywet baywet merged commit b1b010b into main Apr 14, 2023
@baywet baywet deleted the feature/indexers-by branch April 14, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All indexers should be in the format client.Repos.ByOwner() instead of client.ReposByOwner()

2 participants