Implemented AllowedHostsValidator class#1675
Merged
osose-e merged 3 commits intoosose-authentication-featuresfrom Jun 29, 2022
Merged
Implemented AllowedHostsValidator class#1675osose-e merged 3 commits intoosose-authentication-featuresfrom
osose-e merged 3 commits intoosose-authentication-featuresfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
baywet
approved these changes
Jun 29, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
Great work! Couple of suggestions for the next ones:
- Don't forget to link the issue this pull request addresses for traceability with the fixes or partial notation (I've edited your initial comment)
- Small units of progress are great (PR sizing), you could also have left this PR as a draft and kept pushing changes to implement the issue fully.
- Once an issue is completed by a PR, don't forget to add an entry into the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial #1638