Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…ype names in CSHarp Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes a bug where properties could have invalid names (only numbers) - fixes a bug where enum symbols could be invalid Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…ation - fixes a bug where inline request body classes would override each other on multiple operations Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes a bug where CSharp executor method could not have scalar request bodies Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes a bug where model classes would fail to generate if the type wasn't set to object - fixes a bug where flattening compositions for nullable would ignore some type options Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes an issue with inline classes naming Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes a bug wher some code symbols could be only numbers Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…ce id Signed-off-by: Vincent Biret <vibiret@microsoft.com>
- fixes id cleanup regex Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
caf6b24 to
30c3f8b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced May 16, 2022
zengin
reviewed
May 16, 2022
Contributor
zengin
left a comment
There was a problem hiding this comment.
Are our samples extendable to cover the edge cases that @darrelmiller outlined in the linked issue for GitHub API?
Member
Author
|
@zengin do you mean we should add samples for the GitHub API? We could. My bigger challenge at this point is how to scale the samples. Right now the addition, update and validation of samples is manual. I think a good first step would be to have github actions workflows to automate the validation. And then we could add a workflow that updates the samples on every new release or something like that. |
Contributor
|
@baywet, not the entire GitHub API, but to cover some subset which has the multiple indexers in the URL, something like the test cases we have in the Typewriter repo. If it is not scalable at the moment, I think the unit tests are fine for now. |
zengin
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1535
No changes to our samples.