Skip to content

adds support for text plain endpoints#1397

Merged
baywet merged 23 commits intomainfrom
feature/text-plain
Mar 18, 2022
Merged

adds support for text plain endpoints#1397
baywet merged 23 commits intomainfrom
feature/text-plain

Conversation

@baywet
Copy link
Member

@baywet baywet commented Mar 15, 2022 •
edited
Loading

Summary

fixes #878

Adds support for serializing/deserializing scalar values from text/plain content. A good example usage of that is /users/$count which returns the result as text plain.

int? countResult = await client.Users.Count.GetAsync(h => {
    h.Add("ConsistencyLevel", "eventual"); // this header is only required for the identity APIs
});
Console.WriteLine($"users in tenant {countResult}");

Generation diff

microsoft/kiota-samples#565

@baywet baywet added this to the Community Preview milestone Mar 15, 2022
@baywet baywet self-assigned this Mar 15, 2022
andrueastman
andrueastman reviewed Mar 16, 2022
View reviewed changes
@baywet baywet force-pushed the feature/text-plain branch from 0b0895d to deab307 Compare March 16, 2022 12:31
This was referenced Mar 16, 2022
Closed
Closed
baywet added 14 commits March 16, 2022 10:43
@baywet
- udpates documentation for the text/plain support
858b574
@baywet
- updates java, typescript and go refiners to use the default text se…
caad551 
…rializers
@baywet
- adds pipelines for ts, go and java text libs
328c22e
@baywet
- adds go text serialization lib
cbe876e
@baywet
- created java text library structure
e5ce6c9
@baywet
- adds text serialization implementation for Java
4d67922
@baywet
- adds text plain serialization for tyepscript
9cc80ad
@baywet
- docs updates and minor fixes
239b60d
@baywet
- makes text/plain a valid return type
fecf00d
@baywet
- fixes a bug where raw values get in http dotnet would fail
344f396
@baywet
- fixes type mappings for java raw values
e2db6a7 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes a bug where startswith method would not be available on some …
461b146 
…platforms

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds missing mappings for raw values in http ts
fe33ce1
@baywet
- bumps to required abstractions versions
e025e44
@baywet baywet marked this pull request as ready for review March 17, 2022 20:01
@baywet baywet requested a review from andrueastman March 17, 2022 20:02
baywet added 2 commits March 17, 2022 16:02
@baywet
- fixes solution file name
4e4ba26 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds changelog entry for text plain support
2b0e3a8
andrueastman
andrueastman reviewed Mar 18, 2022
View reviewed changes
@baywet
- implementes code review feedback
75d07e7 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.1% 97.1% Coverage
0.0% 0.0% Duplication

@baywet baywet requested a review from andrueastman March 18, 2022 12:49
andrueastman
andrueastman approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet merged commit fb3a584 into main Mar 18, 2022
@baywet baywet deleted the feature/text-plain branch March 18, 2022 13:40
@baywet baywet mentioned this pull request Mar 18, 2022
Closed
@baywet baywet mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

1 more reviewer

@andrueastman andrueastman andrueastman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

Community Preview

Development

Successfully merging this pull request may close these issues.

Support for raw content in text/plain responses

2 participants

@baywet @andrueastman