Fix compliance score calculation in Get-ComplianceReportData#928
Closed
04cb wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix compliance score calculation in Get-ComplianceReportData#92804cb wants to merge 1 commit intomicrosoft:mainfrom
04cb wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The Get-ComplianceReportData function was calculating compliance scores using a confusing formula that derived PinnedDependencies from the difference between total violations and non-Info severity violations. Since no violations are currently assigned 'Info' severity, this resulted in PinnedDependencies always being 0 when violations were found. The fix simplifies the logic to explicitly set PinnedDependencies to 0 and ComplianceScore to 0% when violations are found (since all items in the Violations array are unpinned dependencies), and 100% when no violations are found. This preserves the existing behavior while making the code more maintainable and easier to understand.
Member
|
While there are some potential improvements that can be made in this section of the code, there's no issue filed that demonstrates incorrect behavior of the system or the calculations. Please file an issue first if you believe the calculations are incorrect and we will triage from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The `Get-ComplianceReportData` function was calculating compliance scores using a confusing formula that derived `PinnedDependencies` from the difference between total violations and non-Info severity violations. Since no violations are currently assigned 'Info' severity, this resulted in `PinnedDependencies` always being 0 when violations were found.
The fix simplifies the logic to explicitly set `PinnedDependencies` to 0 and `ComplianceScore` to 0% when violations are found (since all items in the Violations array are unpinned dependencies), and 100% when no violations are found. This preserves the existing behavior while making the code more maintainable and easier to understand.
Changes: