test(scripts): add Pester tests for linting scripts by WilliamBerryiii · Pull Request #237 · microsoft/hve-core

WilliamBerryiii · 2026-01-22T00:40:47Z

Pull Request

Description

Add comprehensive Pester tests for four linting PowerShell scripts. This PR provides complete test coverage for the linting infrastructure and fixes a discovered bug in Link-Lang-Check.ps1.

Changes

New test files (4 files, 1,156 lines total):
- Invoke-LinkLanguageCheck.Tests.ps1 - Tests for link/language validation orchestration
- Invoke-PSScriptAnalyzer.Tests.ps1 - Tests for PowerShell static analysis wrapper
- Link-Lang-Check.Tests.ps1 - Tests for link language checking with npx integration
- Markdown-Link-Check.Tests.ps1 - Tests for markdown link validation with npx integration
Test fixtures (5 files):
- anchors-test.md - Internal anchor link scenarios
- invalid-links.md - Broken URL test cases
- link-check-config.json - Configuration fixture
- mixed-links.md - Combined valid/invalid link scenarios
- valid-links.md - Working URL test cases
Bug fix:
- Link-Lang-Check.ps1 - Fixed array wrapping on Get-Content to handle single-file edge case
Test organization:
- Reorganized test directory structure to mirror source layout (scripts/tests/linting/, scripts/tests/dev-tools/, scripts/tests/extension/, scripts/tests/lib/)

Test Results

192 tests passing (Pester 5.7.1)
PSScriptAnalyzer clean (no warnings)

Related Issue(s)

Closes #231
Closes #190

Type of Change

Select all that apply:

Code & Documentation:

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature causing existing functionality to change)
Documentation update

Infrastructure & Configuration:

AI Artifacts:

Reviewed contribution with prompt-builder agent and addressed all feedback
Copilot instructions (.github/instructions/*.instructions.md)
Copilot prompt (.github/prompts/*.prompt.md)
Copilot agent (.github/agents/*.agent.md)

Other:

Script/automation (.ps1, .sh, .py)
Other (please describe):

Testing

All tests verified locally:

# Run Pester tests
Invoke-Pester -Path ./scripts/tests -Configuration (& ./scripts/tests/pester.config.ps1)
# Result: 192 tests passed

# Run PSScriptAnalyzer on test files
Invoke-PSScriptAnalyzer -Path ./scripts/tests -Recurse
# Result: No warnings

Test coverage includes:

Script	Test Scenarios
`Invoke-LinkLanguageCheck.ps1`	Parameter validation, file discovery, results aggregation, exit codes
`Invoke-PSScriptAnalyzer.ps1`	Settings file handling, custom rules, verbose output, result formatting
`Link-Lang-Check.ps1`	npx integration, file processing, error handling, configuration
`Markdown-Link-Check.ps1`	npx integration, config file support, result parsing, concurrency

Checklist

Required Checks

Documentation is updated (if applicable)
Files follow existing naming conventions
Changes are backwards compatible (if applicable)

AI Artifact Contributions

N/A - This PR contains test files only.

Required Automated Checks

The following validation commands must pass before merging:

Markdown linting: npm run lint:md
Spell checking: npm run spell-check
Frontmatter validation: npm run lint:frontmatter
Link validation: npm run lint:md-links
PowerShell analysis: npm run lint:ps

Security Considerations

This PR does not contain any sensitive or NDA information
Any new dependencies have been reviewed for security issues
Security-related scripts follow the principle of least privilege

Additional Notes

Commits

12c17c2 - test(scripts): add Pester tests for linting scripts
0a2378f - fix(tests): update relative paths after reorganization (Related to [Issue]: Add unit tests for linting scripts to improve code coverage #231)
c223639 - refactor(tests): reorganize test directory to mirror source structure (Related to [Issue]: Add unit tests for linting scripts to improve code coverage #231)

Files Changed (16 total)

File	Change
`scripts/linting/Link-Lang-Check.ps1`	Bug fix
`scripts/tests/Fixtures/Linting/*.md`	New fixtures (5 files)
`scripts/tests/linting/*.Tests.ps1`	New tests (4 files)
`scripts/tests/dev-tools/`	Relocated from root
`scripts/tests/extension/`	Relocated from root
`scripts/tests/lib/`	Relocated from root

- Move Generate-PrReference.Tests.ps1 to dev-tools/ - Move Get-VerifiedDownload.Tests.ps1 to lib/ - Move Package-Extension.Tests.ps1 to extension/ - Move Prepare-Extension.Tests.ps1 to extension/ - Move LintingHelpers.Tests.ps1 to linting/ - Move Validate-MarkdownFrontmatter.Tests.ps1 to linting/ Related to #231 🤖 - Generated by Copilot

Adjust PSScriptRoot-relative paths to source files after moving tests into subdirectories. Related to #231 🤖 - Generated by Copilot

- add unit tests for Invoke-LinkLanguageCheck, Invoke-PSScriptAnalyzer - add unit tests for Link-Lang-Check, Markdown-Link-Check - add test fixtures for markdown link validation scenarios - fix array wrapping bug in Link-Lang-Check.ps1 🧪 - Generated by Copilot

github-actions · 2026-01-22T00:41:02Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Pull request overview

This PR adds comprehensive Pester tests around the linting PowerShell scripts, introduces markdown/link fixtures to exercise those tests, and fixes a single-file edge case in Link-Lang-Check.ps1. It also aligns test script paths with the reorganized scripts/tests/* directory layout.

Changes:

New unit and integration-style Pester suites for Validate-MarkdownFrontmatter.ps1, Markdown-Link-Check.ps1, Link-Lang-Check.ps1, Invoke-PSScriptAnalyzer.ps1, and Invoke-LinkLanguageCheck.ps1, plus shared LintingHelpers tests.
New markdown and JSON fixtures under scripts/tests/Fixtures/Linting/ for valid/invalid links and anchor scenarios.
Bug fix in Find-LinksInFile to always treat Get-Content results as an array, avoiding incorrect behavior on single-line files.
Updated existing tests under scripts/tests/{lib,extension,dev-tools} to match the new directory structure.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`scripts/tests/linting/Validate-MarkdownFrontmatter.Tests.ps1`	Adds unit and integration tests for frontmatter parsing, schema selection/validation, footer detection, git-changed-file grouping, and end-to-end validation behavior.
`scripts/tests/linting/Markdown-Link-Check.Tests.ps1`	Tests `Get-MarkdownTarget` (git-aware and non-git modes), `Get-RelativePrefix`, and validates the link-check JSON config fixture; contains one OS-specific path assertion that will fail on Linux.
`scripts/tests/linting/LintingHelpers.Tests.ps1`	Provides coverage for all exported helpers (changed-files discovery, recursive file enumeration, .gitignore parsing, and GitHub Actions output/env/summary helpers).
`scripts/tests/linting/Link-Lang-Check.Tests.ps1`	Exercises `Get-GitTextFile`, `Find-LinksInFile`, `Repair-LinksInFile`, `Repair-AllLink`, and `ConvertTo-JsonOutput` using temp files to validate detection and repair of `en-us` URLs.
`scripts/tests/linting/Invoke-PSScriptAnalyzer.Tests.ps1`	Adds tests around parameter validation, module-availability handling, file-discovery logic, GitHub Actions integration, JSON output, and exit-code behavior; current “module not installed” test will cause a real `Install-Module` call.
`scripts/tests/linting/Invoke-LinkLanguageCheck.Tests.ps1`	Verifies presence of `Invoke-LinkLanguageCheck.ps1`/`Link-Lang-Check.ps1`, JSON parsing expectations, GitHub Actions helper exports, and basic output/summary semantics.
`scripts/tests/lib/Get-VerifiedDownload.Tests.ps1`	Updates dot-source path to `Get-VerifiedDownload.ps1` to account for the tests being moved under `scripts/tests/lib/`.
`scripts/tests/extension/Prepare-Extension.Tests.ps1`	Adjusts the relative dot-source path to `Prepare-Extension.ps1` to match the new `scripts/tests/extension` layout.
`scripts/tests/extension/Package-Extension.Tests.ps1`	Adjusts the relative dot-source path to `Package-Extension.ps1` after test directory reorganization.
`scripts/tests/dev-tools/Generate-PrReference.Tests.ps1`	Fixes the dot-source path to `Generate-PrReference.ps1` for the new `scripts/tests/dev-tools` location.
`scripts/tests/Fixtures/Linting/valid-links.md`	Fixture file containing only valid internal, external, and anchor links for link-check tests.
`scripts/tests/Fixtures/Linting/mixed-links.md`	Fixture mixing valid and invalid links (missing file, bad anchor) to exercise failure detection.
`scripts/tests/Fixtures/Linting/link-check-config.json`	JSON configuration fixture for `markdown-link-check` tests, including ignore/replacement patterns, headers, timeout, and retry options.
`scripts/tests/Fixtures/Linting/invalid-links.md`	Fixture with broken internal/anchor/malformed links to test error reporting.
`scripts/tests/Fixtures/Linting/anchors-test.md`	Fixture to validate anchor extraction and matching (including headings with dashes, underscores, and uppercase).
`scripts/linting/Link-Lang-Check.ps1`	Fixes `Find-LinksInFile` to wrap `Get-Content` in `@()` so single-line files are always processed as an array of lines.

scripts/tests/linting/Markdown-Link-Check.Tests.ps1

scripts/tests/linting/Invoke-PSScriptAnalyzer.Tests.ps1

- add ExcludePaths parameter to Link-Lang-Check.ps1 - pass ExcludePaths through Invoke-LinkLanguageCheck.ps1 wrapper - update package.json to exclude scripts/tests/** from lint:links 🔧 - Generated by Copilot

- fix BeforeAll path in Generate-PrReference.Tests.ps1 from ../ to ../../ - use IsPathRooted() for cross-platform absolute path validation - mock Install-Module to prevent network calls in unit tests 🔧 - Generated by Copilot

- workflow was calling script directly without exclusion parameter - test files containing intentional 'en-us' URLs are now excluded 🔧 - Generated by Copilot

Copilot

Pull request overview

Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.

scripts/linting/Link-Lang-Check.ps1

…ity scripts - add ExcludePaths filtering tests to Link-Lang-Check.Tests.ps1 - add ExcludePaths filtering tests to Validate-MarkdownFrontmatter.Tests.ps1 - add ExcludePaths filtering tests to Test-DependencyPinning.Tests.ps1 🧪 - Generated by Copilot

- add invocation guard to Test-DependencyPinning.ps1 main block - simplify test file to use dot-source instead of AST extraction - fixes 5 Export-ComplianceReport test failures 🔧 - Generated by Copilot

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

scripts/tests/linting/Invoke-LinkLanguageCheck.Tests.ps1

- rename misleading test to match actual behavior - rewrite GitHub Actions detection test to exercise env var 🧪 - Generated by Copilot

WilliamBerryiii added 3 commits January 21, 2026 15:51

fix(tests): update relative paths after reorganization

0a2378f

Adjust PSScriptRoot-relative paths to source files after moving tests into subdirectories. Related to #231 🤖 - Generated by Copilot

WilliamBerryiii requested a review from a team as a code owner January 22, 2026 00:40

Copilot AI review requested due to automatic review settings January 22, 2026 00:40

Copilot started reviewing on behalf of WilliamBerryiii January 22, 2026 00:41 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

scripts/tests/linting/Markdown-Link-Check.Tests.ps1 Outdated Show resolved Hide resolved

scripts/tests/linting/Invoke-PSScriptAnalyzer.Tests.ps1 Show resolved Hide resolved

WilliamBerryiii added 3 commits January 21, 2026 16:46

fix(scripts): add ExcludePaths parameter to link-lang-check scripts

608d45e

- add ExcludePaths parameter to Link-Lang-Check.ps1 - pass ExcludePaths through Invoke-LinkLanguageCheck.ps1 wrapper - update package.json to exclude scripts/tests/** from lint:links 🔧 - Generated by Copilot

fix(build): add ExcludePaths to link-lang-check workflow

47f84cc

- workflow was calling script directly without exclusion parameter - test files containing intentional 'en-us' URLs are now excluded 🔧 - Generated by Copilot

Copilot AI review requested due to automatic review settings January 22, 2026 00:54

Copilot started reviewing on behalf of WilliamBerryiii January 22, 2026 00:55 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

scripts/linting/Link-Lang-Check.ps1 Show resolved Hide resolved

WilliamBerryiii added 2 commits January 21, 2026 18:12

fix(scripts): resolve PowerShell class type identity mismatch in tests

9003b8d

- add invocation guard to Test-DependencyPinning.ps1 main block - simplify test file to use dot-source instead of AST extraction - fixes 5 Export-ComplianceReport test failures 🔧 - Generated by Copilot

katriendg approved these changes Jan 22, 2026

View reviewed changes

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Merge branch 'main' into test/231-linting-script-tests

4975754

WilliamBerryiii requested a review from Copilot January 22, 2026 18:03

Copilot started reviewing on behalf of WilliamBerryiii January 22, 2026 18:04 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

scripts/tests/linting/Invoke-LinkLanguageCheck.Tests.ps1 Outdated Show resolved Hide resolved

scripts/tests/linting/Invoke-LinkLanguageCheck.Tests.ps1 Show resolved Hide resolved

fix(scripts): address PR review comments in test file

f39c313

- rename misleading test to match actual behavior - rewrite GitHub Actions detection test to exercise env var 🧪 - Generated by Copilot

WilliamBerryiii merged commit 5b65923 into main Jan 22, 2026
15 checks passed

WilliamBerryiii deleted the test/231-linting-script-tests branch January 22, 2026 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(scripts): add Pester tests for linting scripts#237

test(scripts): add Pester tests for linting scripts#237
WilliamBerryiii merged 10 commits intomainfrom
test/231-linting-script-tests

WilliamBerryiii commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

WilliamBerryiii commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Description

Changes

Test Results

Related Issue(s)

Type of Change

Testing

Checklist

Required Checks

AI Artifact Contributions

Required Automated Checks

Security Considerations

Additional Notes

Commits

Files Changed (16 total)

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WilliamBerryiii commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading