-
Notifications
You must be signed in to change notification settings - Fork 125
Description
Summary
The code-review collection contains only three artifacts (1 agent, 1 prompt, 1 shared instruction) and is too small to justify a standalone marketplace extension. Its functional code review agent and prompt fit naturally under the coding-standards collection, which already provides language-specific conventions and quality tooling. Merging the two simplifies the extension landscape and reduces user confusion when choosing which collection to install.
Current State
code-review collection (3 items)
| Kind | Path |
|---|---|
| agent | .github/agents/code-review/functional-code-review.agent.md |
| prompt | .github/prompts/code-review/functional-code-review.prompt.md |
| instruction | .github/instructions/shared/hve-core-location.instructions.md (shared) |
Description: Analyze branch diffs before opening pull requests to catch functional defects early. Provides agents that review changed code for logic errors, edge case gaps, error handling deficiencies, and behavioral bugs.
coding-standards collection (10 items)
| Kind | Path |
|---|---|
| instruction | .github/instructions/coding-standards/bash/bash.instructions.md |
| instruction | .github/instructions/coding-standards/bicep/bicep.instructions.md |
| instruction | .github/instructions/coding-standards/csharp/csharp.instructions.md |
| instruction | .github/instructions/coding-standards/csharp/csharp-tests.instructions.md |
| instruction | .github/instructions/coding-standards/powershell/pester.instructions.md |
| instruction | .github/instructions/coding-standards/powershell/powershell.instructions.md |
| instruction | .github/instructions/coding-standards/python-script.instructions.md |
| instruction | .github/instructions/coding-standards/terraform/terraform.instructions.md |
| instruction | .github/instructions/coding-standards/uv-projects.instructions.md |
| instruction | .github/instructions/shared/hve-core-location.instructions.md (shared) |
Description: Enforce language-specific coding conventions and best practices across your projects.
Proposed Changes
1. Merge artifacts into coding-standards
Add the code-review agent and prompt to coding-standards.collection.yml:
# Agents
- path: .github/agents/code-review/functional-code-review.agent.md
kind: agent
# Prompts
- path: .github/prompts/code-review/functional-code-review.prompt.md
kind: promptAfter the merge, coding-standards grows to 12 items (1 agent, 1 prompt, 10 instructions).
2. Update coding-standards.collection.md
Expand the description to include the code review capabilities:
Enforce language-specific coding conventions and review code for functional correctness. This collection provides instructions for bash, Bicep, C#, PowerShell, Python, and Terraform that are automatically applied based on file patterns, plus agents for pre-PR code review.
Add to the item list:
- Functional Code Review — Diff-based reviewer that identifies logic errors, concurrency issues, contract violations, and testing gaps with severity-ordered findings and concrete fixes
- Functional Code Review Prompt — Quick-launch prompt that delegates to the functional code review agent with base branch input
3. Remove code-review collection files
Delete:
collections/code-review.collection.ymlcollections/code-review.collection.md
4. Update hve-core-all collection
In collections/hve-core-all.collection.yml, remove any items sourced from the code-review collection that now overlap with coding-standards entries. Verify no duplicates after the merge.
5. Regenerate plugins
Run npm run plugin:generate to regenerate plugin outputs after the collection changes.
6. Update any cross-references
Search for references to the code-review collection across:
docs/pagesextension/packaging templatesREADME.md.github/instructions/and.github/agents/
Update or remove references as appropriate.
Acceptance Criteria
-
coding-standards.collection.ymlincludes the functional code review agent and prompt -
coding-standards.collection.mddescribes both coding standards and code review capabilities -
code-review.collection.ymlandcode-review.collection.mdare deleted -
hve-core-all.collection.ymlhas no duplicate entries -
npm run plugin:generatesucceeds and outputs are committed -
npm run lint:collections-metadatapasses -
npm run lint:marketplacepasses - No broken references to the removed
code-reviewcollection remain in docs or config
Related
- feat(docs): Simplify extension install experience with collection showcase and guided RPI tutorial #859 — Collections overview page references this merger