-
Notifications
You must be signed in to change notification settings - Fork 128
Closed
Labels
bugSomething isn't workingSomething isn't workingworkflowsGitHub Actions workflowsGitHub Actions workflows
Description
Problem
The pre-release and release workflows have several issues that can cause version regression and incorrect stable releases under the even/odd marketplace versioning convention (even minor = stable, odd minor = pre-release):
- LAST_TAG picks up pre-release tags —
git describe --tags --abbrev=0inprerelease.ymlcan select an odd-minor pre-release tag as the baseline, causing version regression when computing the next pre-release version. - jq syntax error —
prerelease-release.ymlhas a corrupted//alternative operator in the manifest fallback expression, causing version extraction to fail. - No even-minor guard on release-please —
main.ymldoes not validate that release-please proposes an even minor for stable releases, allowing odd minors to slip through. - Plugin generation missing —
prerelease.ymlbumps version files via jq but never runsnpm run plugin:generate, causing Plugin Validation CI to fail.
Solution
- Filter
LAST_TAGto stable-only (even-minor) tags usingawkinprerelease.yml - Fix jq
//operator syntax inprerelease-release.yml - Add even-minor validation step after release-please in
main.yml - Add Node.js setup, npm ci, and
npm run plugin:generatetoprerelease.yml - Deduplicate
LAST_TAGcomputation between version and changelog steps
Affected Files
.github/workflows/prerelease.yml.github/workflows/prerelease-release.yml.github/workflows/main.yml.github/workflows/extension-publish.yml
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingworkflowsGitHub Actions workflowsGitHub Actions workflows