-
Notifications
You must be signed in to change notification settings - Fork 125
Description
Summary
Collection manifest evaluation identified 3 issues across 11 collections (145 artifacts). Zero duplicates, zero phantom entries, and 100% kind accuracy — but dependency and consistency gaps exist.
Findings
Critical — project-planning.collection.yml missing RPI subagents
project-planning.collection.yml includes hve-core/rpi-agent.agent.md (cross-collection reference) but none of its 5 declared subagents:
.github/agents/hve-core/subagents/researcher-subagent.agent.md.github/agents/hve-core/subagents/plan-validator.agent.md.github/agents/hve-core/subagents/phase-implementor.agent.md.github/agents/hve-core/subagents/rpi-validator.agent.md.github/agents/hve-core/subagents/implementation-validator.agent.md
Installing only the project-planning collection yields a non-functional rpi-agent. Per repo conventions, collections must include all subagent dependencies used by their referenced agents.
Remediation: Add all 5 subagents to project-planning.collection.yml, or remove the rpi-agent.agent.md cross-collection reference.
Major — design-thinking.collection.yml missing shared instruction
design-thinking.collection.yml is the only non-trivial collection (2 agents, 13 prompts, 42 instructions) missing shared/hve-core-location.instructions.md. All 8 other collections with agents or instructions include it.
Remediation: Add to design-thinking.collection.yml:
- path: .github/instructions/shared/hve-core-location.instructions.md
kind: instructionMinor — experimental.collection.yml missing shared instruction
experimental.collection.yml also lacks the shared instruction. Lower impact since it currently contains only a single skill (video-to-gif), but inconsistent with the pattern.
Remediation: Add the same shared instruction entry if the collection is expected to grow.
Verification Summary
| Check | Result |
|---|---|
| Duplicates within any collection | 0 — clean |
| Phantom entries (YAML path → no file on disk) | 0 — clean |
| Kind correctness | 100% |
hve-core-all completeness |
100% (143/143 eligible) |
| Repo-specific exclusions | Correct — 2 root instructions properly excluded |
| Subagent dependency coverage | 1 gap (project-planning) |
Acceptance Criteria
-
project-planning.collection.ymlincludes all 5 RPI subagents (or removes the rpi-agent reference) -
design-thinking.collection.ymlincludesshared/hve-core-location.instructions.md -
experimental.collection.ymlincludesshared/hve-core-location.instructions.md(optional, minor) -
npm run plugin:generatecompletes successfully -
npm run lint:collections-metadatapasses