fix(build): use draft releases for VSIX upload#338
Merged
WilliamBerryiii merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
- add draft: true to release-please-config.json - add publish step using gh release edit --draft=false Fixes #335 📦 - Generated by Copilot
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the release workflow to avoid GitHub’s “immutable release” restriction by ensuring VSIX assets are uploaded while the GitHub Release is still a draft, then publishing it afterward.
Changes:
- Configure release-please to create draft releases.
- Publish the GitHub Release after VSIX upload via
gh release edit --draft=false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release-please-config.json |
Enables draft releases to allow post-creation asset uploads. |
.github/workflows/main.yml |
Adds a step to publish the release after uploading the VSIX asset. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 41.08% 41.04% -0.04%
==========================================
Files 15 15
Lines 2870 2870
==========================================
- Hits 1179 1178 -1
- Misses 1691 1692 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nguyena2
approved these changes
Jan 28, 2026
WilliamBerryiii
pushed a commit
that referenced
this pull request
Jan 28, 2026
🤖 I have created a release *beep* *boop* --- ## [2.0.1](hve-core-v2.0.0...hve-core-v2.0.1) (2026-01-28) ### 🐛 Bug Fixes * **build:** use draft releases for VSIX upload ([#338](#338)) ([f1d3ac6](f1d3ac6)) * **docs:** quote YAML frontmatter values in BRD template ([#339](#339)) ([ca988f2](ca988f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
This was referenced Jan 28, 2026
This was referenced Feb 6, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes HTTP 422 error "Cannot upload assets to an immutable release" when uploading VSIX to GitHub releases. The repository has GitHub's immutable releases feature enabled, which prevents modifications to published releases.
This PR:
"draft": trueat the root level ofrelease-please-config.json(applies globally to all packages)gh release edit --draft=falseNote: The
"draft": truesetting is placed at the root level rather than underpackages["."]because release-please supports both locations, and root-level applies the setting globally. Since this repository has a single package, root-level placement is cleaner and functionally equivalent.Related Issue(s)
Fixes #335
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md)Other:
.ps1,.sh,.py)Testing
gh release edit --draft=falsecommand syntax against GitHub CLI documentationdraftconfig option behavior at both root and package levelsChecklist
Required Checks
Required Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run lint:md-linksnpm run lint:psSecurity Considerations
Additional Notes
The workflow uses the existing
github.tokenwhich already hascontents: writepermission configured in thepublish-extensionjob.