[RFC] Upgrade containerd/cgroups #1356
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1c7dc6 to
9fa7d45
Compare
dc43d26 to
4db063a
Compare
Contributor
|
Interesting; looks like a panic happening; |
03696da to
74a8353
Compare
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the way to upgrade containerd/cgroups.
Why?
We have migrated from gogo/protobuf to Google's official protobuf package in containerd/containerd and containerd/cgroups, since gogo/protobuf was sadly deprecated by the authors.
Since hcsshim is embedding containerd/cgroups' proto-generated structs in its own stats structs, in order to upgrade containerd/cgroups, we have to use Google's protobuf package to generate the stats structs.
Do we really need to upgrade containerd/cgroups right now?
No. The migration PR has been merged after all bug fixes. In addition to that, we agreed to have a new branch for folks who cannot use Google's protobuf package at this time.