fix integration test failure (#1799)

helsaawy · web-flow · commit f5c5797f7889 · 2023-06-02T20:38:06.000-04:00
Signed-off-by: Hamza El-Saawy &lt;hamzaelsaawy@microsoft.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -373,21 +373,18 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      # needs to be a separate step since terminal reload is required to bring in new env variables and PATH
+      - name: Upgrade Chocolaty
+        shell: powershell
+        run: |
+          choco upgrade -y chocolatey 2>&1
+
       - name: Install mingw
         shell: powershell
         run: |
           $VerbosePreference = 'Continue'
           # dont set $ErrorActionPreference since we want to allow choco install to fail later on
 
-          Write-Output '::group::Update chocolaty'
-          choco upgrade -y chocolatey
-          Write-Output '::endgroup::'
-
-          if ( $LASTEXITCODE ) {
-            Write-Output '::error::Could not update chocolatey.'
-            exit $LASTEXITCODE
-          }
-
           Write-Output 'Install mingw'
           # Install sometimes fails when downloading mingw zip from source-forge with:
           #  "ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url"
@@ -404,7 +401,7 @@ jobs:
               Sleep -Seconds 60
             }
 
-            choco install -y --no-progress --stop-on-first-failure --force mingw --allow-downgrade --version 10.2.0
+            choco install -y --no-progress --stop-on-first-failure --force mingw --allow-downgrade --version 10.3.0
             Write-Output '::endgroup::'
             if ( -not $LASTEXITCODE ) {
               Write-Output "Attempt $i succeeded (exit code: $LASTEXITCODE)"
@@ -418,6 +415,9 @@ jobs:
             exit $LASTEXITCODE
           }
 
+          # verify mingw32-make was installed
+          Get-Command -CommandType Application -ErrorAction Stop mingw32-make.exe
+
       - name: Build binaries
         shell: bash
         working-directory: src/github.com/containerd/containerd
