Improve speed of serializer test function#516
Merged
layershifter merged 3 commits intomicrosoft:mainfrom Mar 19, 2024
Merged
Conversation
📊 Bundle size report🤖 This report was generated against 3e815c80ed89c72c8a81b5d8082cac7e8bb7a285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testfunction for the serializer plugin is called many times (from jest docs)Using the serializer for many elements causes a large slowdown due to the fact it constructs a large regex every time it's called

I believe this can be improved because
DEBUG_RESET_CLASSESandDEFINITION_LOOKUP_TABLEare maps so we should be able to lookup a class without doing a string searchThis PR changes the

testfunction to use a faster implementationSimple benchmark test - https://jsperf.app/nevedi