fix(style-types): use custom fallback type#511
Merged
layershifter merged 3 commits intomainfrom Mar 19, 2024
Merged
Conversation
📊 Bundle size reportUnchanged fixtures
|
Hotell
reviewed
Mar 4, 2024
|
|
||
| const { width = '1px', style = 'solid', color = 'red' } = options; | ||
|
|
||
| expect(borderBottom(width, style, color)).toEqual({ |
Contributor
There was a problem hiding this comment.
wondering if we should introduce test for all possible cases that can occur in order to mitigate future breaking changes on csstype level ?
Member
Author
There was a problem hiding this comment.
The test for other cases already exists, https://github.com/microsoft/griffel/blob/main/e2e/typescript/src/assets/fixture.ts.
Hotell
reviewed
Mar 4, 2024
Contributor
Hotell
left a comment
There was a problem hiding this comment.
verified that this fix resolves issue with using private interface property types within fluent
Hotell
reviewed
Mar 4, 2024
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
ling1726
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510.