feat: add support for style resets in makeStyles#450
Merged
layershifter merged 3 commits intomicrosoft:mainfrom Apr 11, 2024
Merged
feat: add support for style resets in makeStyles#450layershifter merged 3 commits intomicrosoft:mainfrom
layershifter merged 3 commits intomicrosoft:mainfrom
Conversation
bd29b06 to
564ea3e
Compare
📊 Bundle size reportUnchanged fixtures
|
5409fbb to
8c69975
Compare
8c69975 to
167328c
Compare
ling1726
reviewed
Apr 10, 2024
ling1726
reviewed
Apr 10, 2024
ling1726
reviewed
Apr 10, 2024
ling1726
reviewed
Apr 10, 2024
9f78fb0 to
16478d2
Compare
george-cz
approved these changes
Apr 11, 2024
16478d2 to
eb0b1e5
Compare
ling1726
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #442.
This PR adds support for
RESETvalues inmakeStyles()calls, for example:In this case, nothing will be applied to a
div. This feature becomes useful for merging cases, for example:Note on
makeStyles()&makeResetStyles()comboRESETvalues work only formakeStyles()calls i.e. it won't remove/reset values created bymakeResetStyles().