Skip to content

Extend GrantVmGroupAccess to support write/execute/all permissions.#243

Closed
anmaxvl wants to merge 1 commit intomicrosoft:masterfrom
anmaxvl:feat/extend-grantvmgroupaccess-permissions
Closed

Extend GrantVmGroupAccess to support write/execute/all permissions.#243
anmaxvl wants to merge 1 commit intomicrosoft:masterfrom
anmaxvl:feat/extend-grantvmgroupaccess-permissions

Conversation

@anmaxvl
Copy link
Copy Markdown
Contributor

@anmaxvl anmaxvl commented Apr 6, 2022

Add masks for GENERIC_WRITE, GENERIC_EXECUTE, GENERIC_ALL and update
function signatures accordingly.

Add unit tests for file and directory grant access.

Signed-off-by: Maksim An maksiman@microsoft.com

Add masks for GENERIC_WRITE, GENERIC_EXECUTE, GENERIC_ALL and update
function signatures accordingly.

Add unit tests for file and directory grant access.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner April 6, 2022 22:34
@kevpar
Copy link
Copy Markdown
Member

kevpar commented Apr 7, 2022

Given how VM-specific this code is, maybe we should just move it under internal in hcsshim instead?

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Apr 7, 2022

Given how VM-specific this code is, maybe we should just move it under internal in hcsshim instead?

yeah, sure. I can do that.

@anmaxvl anmaxvl closed this Apr 7, 2022
@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Apr 7, 2022

Port PR: microsoft/hcsshim#1347

@anmaxvl anmaxvl deleted the feat/extend-grantvmgroupaccess-permissions branch April 7, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants