Updating windows build constraints#241
Merged
helsaawy merged 1 commit intomicrosoft:masterfrom Mar 29, 2022
Merged
Conversation
pkg/guid is not windows specific, as it can run on Linux. Build constraints on guid_windows and guid_nonwindows are redundant with file names, but added for consistency. Added missing build constraints. Added Ubuntu to test matrix, along with windows 2022. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
katiewasnothere
approved these changes
Mar 29, 2022
katiewasnothere
left a comment
There was a problem hiding this comment.
LGTM, I don't see any issue doing this
anmaxvl
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#191 added build guard to go-winio, but "pkg/guid" now works on both windows and linux, and is not OS dependent.
This PR is needed to allow using windows-style GUIDs on Linux code that interops with Windows.
Removed build guards from pkg/guid/guid.go.
Build constraints to guid_windows and guid_nonwindows, which redundant with file names, but added for consistency.
Added missing build constraints to other files.
Added Ubuntu to test matrix, along with windows 2022.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com