Skip to content

Add CI github action for testing on push and PR#205

Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:gh_actions
Apr 21, 2021
Merged

Add CI github action for testing on push and PR#205
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:gh_actions

Conversation

@katiewasnothere
Copy link

This PR additionally updates the TestGrantVmGroupAccess test to account for running on a machine that doesn't have support for running hyper-v VMs, which is the current case for github hosted windows images.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner April 21, 2021 21:23
@dcantah
Copy link
Contributor

dcantah commented Apr 21, 2021

Can we add -gcflags=all=-d=checkptr to the go test? It's caught a lot of stuff for hcsshim that we fixed

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@katiewasnothere katiewasnothere merged commit 3e47278 into microsoft:master Apr 21, 2021
@katiewasnothere katiewasnothere deleted the gh_actions branch April 21, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants