[Temporary] Revert Implement winio.GetFileStandardInfo FileInfo commits #204
Merged
katiewasnothere merged 2 commits intomicrosoft:masterfrom Apr 22, 2021
Merged
Conversation
added 2 commits
April 21, 2021 12:49
Author
Contributor
|
Thank you 🙏 Was it a clean revert? (making sure if reviewers need to pay extra attention to the changes) |
Author
@thaJeztah yep! just git reverted and that was it. |
TBBle
approved these changes
Apr 22, 2021
Contributor
There was a problem hiding this comment.
A clean revert is what I expected, since these APIs were introduced to support microsoft/hcsshim#901 and that hasn't landed yet, so the only extant users were the tests, also reverted here.
Maybe title the PR "Temporarily revert ..." so no one gets the impression that we don't want this API after all? ^_^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue mentioned in moby/moby#42307