Skip to content

Add protocol.file.allow=always sync test fix #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagood merged 1 commit into from
Oct 21, 2022
Merged

Add protocol.file.allow=always sync test fix #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sync/sync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,14 @@ func setupMockRepo(dir, branch string) error {
}

func addMockSubmodule(dir, upstream string) error {
if err := runGit(dir, "submodule", "add", upstream, "go"); err != nil {
// "protocol.file.allow=always" lets the submodule command clone from a local directory. It's
// necessary as of Git 2.38.1, where the default was changed to "user" in response to
// CVE-2022-39253. It isn't a concern here where all repos involved are trusted. For more
// information, see:
// https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253
// https://bugs.launchpad.net/ubuntu/+source/git/+bug/1993586
// https://git-scm.com/docs/git-config#Documentation/git-config.txt-protocolallow
if err := runGit(dir, "-c", "protocol.file.allow=always", "submodule", "add", upstream, "go"); err != nil {
return err
}
if err := runGit(dir, "commit", "-m", "Add submodule"); err != nil {
Expand Down