Add TLS13-KDF support for openssl backend#1654
Merged
dagood merged 2 commits intomicrosoft:microsoft/mainfrom Apr 28, 2025
Merged
Add TLS13-KDF support for openssl backend#1654dagood merged 2 commits intomicrosoft:microsoft/mainfrom
dagood merged 2 commits intomicrosoft:microsoft/mainfrom
Conversation
nicholasberlin
commented
Apr 24, 2025
| +// the underlying functions because the TLS 1.3 KDF does not have a standard of | ||
| +// its own. | ||
| + | ||
| +func checkFIPS140Only[Hash hash.Hash](h func() Hash, key []byte) error { |
Contributor
Author
There was a problem hiding this comment.
this function is copy-pasted from ./src/crypto/hkdf/hkdf.go
any refactoring suggestions? export the function?
Member
There was a problem hiding this comment.
tls13.ExpandLabel is an internal API that's not reachable by the user, but only by crypto/tls. That package only uses FIPS-compliant parameters when calling tls13.ExpandLabel, so there is nothing to check here. You can remove this function.
f129585 to
c765878
Compare
8 tasks
Contributor
Author
|
@microsoft-github-policy-service agree company="Elastic" |
c765878 to
1f5e531
Compare
- Update golang-fips to c494c21 - Use new functions in openssl backend - Add stub functions for other backends
Contributor
Author
|
Ok, managed to "rebase". |
dagood
approved these changes
Apr 28, 2025
Member
|
In case that merge commit looks odd to anyone else--rest assured, it's a merge commit. I think I just got bit by a GitHub UI bug that applied the squash-style message to a merge commit. 😕 |
This was referenced Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #1626
Add TLS13-KDF support