Skip to content

Fix the MSVC build#276

Merged
dscho merged 1 commit intomicrosoft:vfs-2.27.0from
dscho:fix-msvc-build
Jun 4, 2020
Merged

Fix the MSVC build#276
dscho merged 1 commit intomicrosoft:vfs-2.27.0from
dscho:fix-msvc-build

Conversation

@dscho
Copy link
Member

@dscho dscho commented Jun 4, 2020

This fixes #275

In 897d68e (Makefile: use curl-config --cflags, 2020-03-26), we
taught the build process to use `curl-config --cflags` to make sure that
it can find cURL's headers.

In the MSVC build, this is completely bogus because we're running in a
Git for Windows SDK whose `curl-config` supports the _GCC_ build.

Let's just ignore each and every `-I<path>` option where `<path>` points
to GCC/Clang specific headers.

Reported by Jeff Hostetler in
microsoft#275.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested a review from jeffhostetler June 4, 2020 14:27
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@dscho dscho merged commit 4f88bb7 into microsoft:vfs-2.27.0 Jun 4, 2020
@dscho dscho deleted the fix-msvc-build branch June 4, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd compile error with RES_STARTEND and regex.h version on MSVC build

3 participants