Update build logic to a real build system#17
Merged
JasonVMo merged 16 commits intomicrosoft:masterfrom Aug 26, 2019
Merged
Conversation
kenotron
reviewed
Aug 26, 2019
kenotron
left a comment
There was a problem hiding this comment.
Some comments left about the extraneous change file conversion scripts. In general, looks okay... since they're from UI Fabric web :)
There was a problem hiding this comment.
BTW, are these changes really needed? We shouldn't need to specify index like this. If we find that the compilation fails because of this, we should fix the configs.
Contributor
Author
There was a problem hiding this comment.
At some point I was hitting errors saying that these weren't targeting a physical file. I think in Fabric there is a forwarding file for controls. So there is a Pressable.ts that imports Pressable/index (I think).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the build logic to use just + beachball. The initial source was copied from fabric but the change has some additional twists:
This also includes the incremental build support Ken added for Fabric with his lerna change. Now builds will clean, lint, build, test, and run webpack.
It is likely there are still places where the build logic can be simplified to be closer to standard approaches. Wherever we can cut things out we should unless there is a good reason for them.
Issues fixed in this change:
I also opened Issue #16 to cover switching from tslint to eslint