Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

I observed that bottomSheetView's accessibilityIdentifier was incorrect when the sheet entered the expanded state. The root cause is that the methods which append strings to the identifier can be invoked multiple times without checking whether the substring already exists, which leads to the incorrect identifier.

Fix:

• A private method bottomSheetViewAccessibilityIdentifierForState that performs the necessary state checks and returns the correct accessibilityIdentifier for bottomSheetView.
• Replace every place that previously appended substrings to bottomSheetView.accessibilityIdentifier with a call to bottomSheetViewAccessibilityIdentifier

Binary change

NA

Verification

I valided using the debugger that the bottomSheetView accessibilityIdentifier is set correctly for each of the different states.

I validated that the BottomSheetControllerTest XCUI tests pass with the changes in place.

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)