Skip to content

Fix CommandBar background color#2204

Merged
joannaquu merged 2 commits intomicrosoft:mainfrom
joannaquu:joannaqu/ccb-bg-color
Sep 9, 2025
Merged

Fix CommandBar background color#2204
joannaquu merged 2 commits intomicrosoft:mainfrom
joannaquu:joannaqu/ccb-bg-color

Conversation

@joannaquu
Copy link
Copy Markdown
Contributor

@joannaquu joannaquu commented Sep 8, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

CommandBar's backgroundColor was never being set (we externally set it in the demo controller). Update it to design's background2

While I'm here, delete unused contentEdgeInsets

Verification

Visual Verification
Before After
light before light after
dark before dark after
override before override after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)

@joannaquu joannaquu requested a review from a team as a code owner September 8, 2025 19:35
@joannaquu joannaquu merged commit e155bed into microsoft:main Sep 9, 2025
12 of 13 checks passed
@joannaquu joannaquu deleted the joannaqu/ccb-bg-color branch September 9, 2025 15:12
@joannaquu joannaquu mentioned this pull request Oct 23, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants