Handle resizing handle taps for partial state#2190
Merged
lukas-cap merged 1 commit intomicrosoft:mainfrom Jul 16, 2025
Merged
Conversation
Saadnajmi
approved these changes
Jul 15, 2025
sharath273kumar
approved these changes
Jul 16, 2025
nodes11
approved these changes
Jul 16, 2025
mischreiber
reviewed
Jul 16, 2025
mischreiber
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Currently a11y users have no way to reach the partially expanded state using the resizing handle taps. Let's make sure we cycle through all of them. The behavior is analogous to system sheets.
I factored out the next state determination to avoid duplicating logic between the tap handler and
updateResizingHandleViewAccessibility.Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Manual testing in demo app + a11y inspector.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow