Conversation
mischreiber
approved these changes
Jun 12, 2025
Sources/FluentUI_iOS/Components/Navigation/UINavigationItem+Navigation.swift
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
There is a new subtitle added to the UINavigationItem on iOS 26 https://developer.apple.com/documentation/uikit/uinavigationitem/subtitle. This conflicts with the existing fluent subtitle so let's make that obsolete for iOS 26.0 to fix build break with Xcode 26 beta.
Verification
Builds fine on Xcode 26 beta. Subtitle shows up on iOS 26 with the system subtitle.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow