Skip to content

Mark TokenSetKey as Sendable#2176

Merged
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:TokenSetKey-Sendable
Jun 10, 2025
Merged

Mark TokenSetKey as Sendable#2176
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:TokenSetKey-Sendable

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jun 9, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Xcode 26 is a bit more sensitive about marking types as Sendable. While we're still working towards full Swift 6 compatibility, this will unblock building FluentUI on the new compiler.

Verification

Apps build and runs on both Xcode 16.4 and 26b1.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner June 9, 2025 23:25
Copy link
Copy Markdown
Contributor

@eschwieb eschwieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mischreiber mischreiber enabled auto-merge (squash) June 9, 2025 23:27
@mischreiber mischreiber merged commit 522f01b into microsoft:main Jun 10, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants