Skip to content

Check build environment for PlatformProviding#2175

Merged
mischreiber merged 3 commits intomicrosoft:mainfrom
mischreiber:PlatformProvidingIfChecks
Jun 10, 2025
Merged

Check build environment for PlatformProviding#2175
mischreiber merged 3 commits intomicrosoft:mainfrom
mischreiber:PlatformProvidingIfChecks

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jun 6, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Fetch our Platform[*]Providing protocols differently depending on the build system.

  • SPM and Cocoapods: we're crossing a module boundary, so stick with the conditional conversion.
  • Manual pull of code into repo: all the same module, so no conditional required.

Verification

No functional change. Builds and runs across multiple build systems.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested review from a team as code owners June 6, 2025 17:49
Copy link
Copy Markdown
Contributor

@DanielMorM DanielMorM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike!

@mischreiber mischreiber force-pushed the PlatformProvidingIfChecks branch from ab4c0f1 to c87fcec Compare June 6, 2025 19:13
@mischreiber mischreiber enabled auto-merge (squash) June 6, 2025 19:22
@mischreiber mischreiber disabled auto-merge June 7, 2025 00:37
@mischreiber mischreiber enabled auto-merge (squash) June 7, 2025 00:37
@mischreiber mischreiber disabled auto-merge June 9, 2025 19:54
@mischreiber mischreiber enabled auto-merge (squash) June 10, 2025 03:52
@mischreiber mischreiber merged commit d052bd7 into microsoft:main Jun 10, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants