Skip to content

Move FluentThemeable implementation to FluentUI_common#2174

Merged
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:FluentThemeableInCommon
Jun 6, 2025
Merged

Move FluentThemeable implementation to FluentUI_common#2174
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:FluentThemeableInCommon

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jun 6, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

This moves the duplicate implementations of FluentThemeable for NSView and UIView into a shared file in FluentUI_common.

No more duplcation, and also preemptively solves a problem with Swift 6 that would require @retroactive.

Verification

No functionality changes. Code builds and demos run as expected on all platforms.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner June 6, 2025 06:38
@mischreiber mischreiber enabled auto-merge (squash) June 6, 2025 06:40
@mischreiber mischreiber merged commit 9f4d228 into microsoft:main Jun 6, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants