Updating CI pipeline to show failures correctly#2162
Merged
mischreiber merged 10 commits intomicrosoft:mainfrom May 27, 2025
Merged
Updating CI pipeline to show failures correctly#2162mischreiber merged 10 commits intomicrosoft:mainfrom
mischreiber merged 10 commits intomicrosoft:mainfrom
Conversation
Contributor
|
latest failure tells me our ci has been broken since macOS 13... oh boy 😅 |
anandrajeswaran
approved these changes
May 23, 2025
anandrajeswaran
approved these changes
May 23, 2025
joannaquu
reviewed
May 23, 2025
Demos/FluentUIDemo_iOS/FluentUIDemoTests/NotificationViewTest_SwiftUI.swift
Show resolved
Hide resolved
joannaquu
approved these changes
May 23, 2025
Saadnajmi
reviewed
May 23, 2025
amoggo
approved these changes
May 23, 2025
joannaquu
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Recently, there have been cases where our pull request validation builds in
ci.ymlwould fail, but the pipeline would still be marked as successful. This makes two changes to resolve this:set -o pipefailto handle failures in the build itself, not just inxcbeautifycontinue-on-errorso the stage will fail properlyVerification
Builds with broken issues (as tested earlier in this PR) actually fail checks and are blocked from merging!
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow