Skip to content

Updating CI pipeline to show failures correctly#2162

Merged
mischreiber merged 10 commits intomicrosoft:mainfrom
mischreiber:fixBrokenCI
May 27, 2025
Merged

Updating CI pipeline to show failures correctly#2162
mischreiber merged 10 commits intomicrosoft:mainfrom
mischreiber:fixBrokenCI

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented May 22, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Recently, there have been cases where our pull request validation builds in ci.yml would fail, but the pipeline would still be marked as successful. This makes two changes to resolve this:

  • Include set -o pipefail to handle failures in the build itself, not just in xcbeautify
  • Remove continue-on-error so the stage will fail properly

Verification

Builds with broken issues (as tested earlier in this PR) actually fail checks and are blocked from merging!

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner May 22, 2025 18:35
@mischreiber mischreiber changed the title [DRAFT] Test removing xcbeautify Updating CI pipeline to show failures correctly May 22, 2025
@joannaquu
Copy link
Copy Markdown
Contributor

latest failure tells me our ci has been broken since macOS 13... oh boy 😅

@mischreiber mischreiber enabled auto-merge (squash) May 23, 2025 03:44
@mischreiber mischreiber requested a review from a team as a code owner May 23, 2025 19:33
@mischreiber mischreiber merged commit 217ec84 into microsoft:main May 27, 2025
7 checks passed
@mischreiber mischreiber deleted the fixBrokenCI branch May 27, 2025 18:17
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants