Move vision token file to FluentUI_common module#2161
Merged
joannaquu merged 1 commit intomicrosoft:mainfrom May 22, 2025
Merged
Move vision token file to FluentUI_common module#2161joannaquu merged 1 commit intomicrosoft:mainfrom
joannaquu merged 1 commit intomicrosoft:mainfrom
Conversation
mischreiber
approved these changes
May 22, 2025
Collaborator
mischreiber
left a comment
There was a problem hiding this comment.
We can take this change to unblock the build for right now, but I'm working on a new way to inject platform-specific tokens. It's intended for macOS, but visionOS will benefit as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Although theoretically we only need the vision token file in the iOS module, we still reference it in the common module in
FluentTheme.swift. Moving it toFluentUI_common.Verification
Demo app builds
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow