Skip to content

Fixing broken dark mode colors in iOS 17#2156

Merged
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:darkModeColors
May 15, 2025
Merged

Fixing broken dark mode colors in iOS 17#2156
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:darkModeColors

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented May 15, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The APIs for creating a UIColor from SwiftUI Color don't work properly on iOS 17 when the Color is dynamic. This works fine on iOS 18, but results in dark mode issues on iOS 17.

Solution: reverting back to an older implementation of UIColor creation, with a few extra public markers to make it work in the new Fluent infrastructure.

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner May 15, 2025 06:35
@mischreiber mischreiber requested a review from a team May 15, 2025 17:36
@mischreiber mischreiber merged commit f55ce02 into microsoft:main May 15, 2025
7 checks passed
@mischreiber mischreiber deleted the darkModeColors branch May 15, 2025 17:50
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants