Fixing broken dark mode colors in iOS 17#2156
Merged
mischreiber merged 2 commits intomicrosoft:mainfrom May 15, 2025
Merged
Conversation
nodes11
approved these changes
May 15, 2025
lukas-cap
approved these changes
May 15, 2025
nodes11
approved these changes
May 15, 2025
joannaquu
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The APIs for creating a UIColor from SwiftUI Color don't work properly on iOS 17 when the Color is dynamic. This works fine on iOS 18, but results in dark mode issues on iOS 17.
Solution: reverting back to an older implementation of UIColor creation, with a few extra public markers to make it work in the new Fluent infrastructure.
Verification
(how the change was tested, including both manual and automated tests)
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow