Skip to content

[SearchBar] Expose keyboard return type property#2151

Merged
huwilkes merged 6 commits intomicrosoft:mainfrom
nabil-k:searchbar_customkeyboardreturntype
May 13, 2025
Merged

[SearchBar] Expose keyboard return type property#2151
huwilkes merged 6 commits intomicrosoft:mainfrom
nabil-k:searchbar_customkeyboardreturntype

Conversation

@nabil-k
Copy link
Copy Markdown
Contributor

@nabil-k nabil-k commented May 12, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Exposed the ability to set the keyboard return type for the SearchBar component.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Added an example to the test app and observed the return key type was being set successfully. By default for the search bar the return key type is "search". When we override it to "done" it appears as "done" in the keyboard.

Visual Verification
Before (Default) After (Overridden as "done")
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nabil-k nabil-k marked this pull request as ready for review May 12, 2025 17:56
@nabil-k nabil-k requested a review from a team as a code owner May 12, 2025 17:56
@nabil-k nabil-k changed the title [SearchBar] Exposed keyboard return type property [SearchBar] Expose keyboard return type property May 12, 2025
@huwilkes huwilkes merged commit d29fe69 into microsoft:main May 13, 2025
7 checks passed
@huwilkes huwilkes requested a review from a team May 13, 2025 17:08
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants