Skip to content

Setting Unique tabID for tabBarItems#2148

Merged
lukas-cap merged 5 commits intomicrosoft:mainfrom
shantanu9890:main
May 8, 2025
Merged

Setting Unique tabID for tabBarItems#2148
lukas-cap merged 5 commits intomicrosoft:mainfrom
shantanu9890:main

Conversation

@shantanu9890
Copy link
Copy Markdown
Contributor

@shantanu9890 shantanu9890 commented May 5, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

  • Setting tabID for tabBarItems to uniquely identify tab bar item view.
  • Will be required to uniquely identify view element for the purpose of showing tooltip.

Binary change

Negligible

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)

@shantanu9890 shantanu9890 marked this pull request as ready for review May 5, 2025 08:31
@shantanu9890 shantanu9890 requested a review from a team as a code owner May 5, 2025 08:31
@lukas-cap
Copy link
Copy Markdown
Contributor

@shantanu9890
I made the change Joanna mentioned you wanted to make. Completing this to include in a bigger update I'm doing.

@lukas-cap lukas-cap merged commit 62e5452 into microsoft:main May 8, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants