Add support for a UIBlurEffect Background to the BottomSheetController#2146
Merged
amoggo merged 8 commits intomicrosoft:mainfrom May 6, 2025
Merged
Conversation
joannaquu
reviewed
May 5, 2025
Sources/FluentUI_iOS/Components/Bottom Commanding/BottomCommandingController.swift
Outdated
Show resolved
Hide resolved
joannaquu
reviewed
May 5, 2025
Sources/FluentUI_iOS/Components/Bottom Sheet/BottomSheetTokenSet.swift
Outdated
Show resolved
Hide resolved
lukas-cap
approved these changes
May 5, 2025
mischreiber
reviewed
May 5, 2025
Sources/FluentUI_iOS/Components/Bottom Sheet/BottomSheetController.swift
Show resolved
Hide resolved
lukas-cap
approved these changes
May 6, 2025
Contributor
|
One thing we should do after - should add a case or toggle using this new behavior to the demo app |
joannaquu
reviewed
May 7, 2025
| /// - Parameters: | ||
| /// - contentViewController: View controller that will be displayed below the bottom commanding UI. | ||
| /// - bottomSheetControllerStyle: The style override for the BottomSheet's background material. | ||
| @objc public init(with contentViewController: UIViewController?, bottomSheetControllerStyle: BottomSheetControllerStyle) { |
Contributor
There was a problem hiding this comment.
seems minor but since it's a part of our public api, can we rename this to style to match our other controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
DESCRIPTION
ShadowInfo:applyShadow:to:. This applyShadow API adds additional CALayers (configured with shadow properties) as shadow layers to the View essentially relying on the view having an opaque backgroundColor for the shadow to show (the opacity of the backgroundColor is directly proportional to the shadow opacity). But when using a UIVisualEffectsView, we can't set an opaque backgroundColor, as it would obstruct the content blurring/sampling feature of this special effects view and would defeat the purpose of using it entirely. So directly add the Shadow tokens to the UIVisualEffectsView layer.Verification
let bottomCommandingVC = BottomCommandingController(with: optionTableViewController, usesBlurEffectBackgroundForBottomSheet: true)in the corresponding demo controller.Visual Verification (NOTE: very subtle difference - there's a blue color bleed through under the Mode button
Pull request checklist
This PR has considered: