Skip to content

Adding nsfont+extension and test view controller#2145

Merged
mischreiber merged 4 commits intomicrosoft:mainfrom
veronicasalas:addExtensionForFluentFontOnMac
May 7, 2025
Merged

Adding nsfont+extension and test view controller#2145
mischreiber merged 4 commits intomicrosoft:mainfrom
veronicasalas:addExtensionForFluentFontOnMac

Conversation

@veronicasalas
Copy link
Copy Markdown
Contributor

@veronicasalas veronicasalas commented Apr 30, 2025 •
edited
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Creating the NSFont+Extensions in order to use Fluent Typography on MacOS

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

To test the changes, I created the TestTypographyViewController.swift which I then added to the existing TestViewControlers.swift

Visual Verification
Before After
None typography_fluentui_apple_mac_light_mode
None typography_fluentui_apple_mac_dark_mode

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

mischreiber
mischreiber reviewed Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Can you verify that toggling the system from light to dark mode correctly updates the fonts?

@veronicasalas veronicasalas marked this pull request as ready for review April 30, 2025 23:34
@veronicasalas veronicasalas requested a review from a team as a code owner April 30, 2025 23:34
joannaquu
joannaquu reviewed Apr 30, 2025
View reviewed changes
@mischreiber
Copy link
Copy Markdown
Collaborator

mischreiber commented May 2, 2025

I'm currently investigating the pod lib lint failure -- I don't see an obvious issue in the code, so there's likely something else going on here.

@veronicasalas
Copy link
Copy Markdown
Contributor Author

veronicasalas commented May 2, 2025

I'm currently investigating the pod lib lint failure -- I don't see an obvious issue in the code, so there's likely something else going on here.

Could it potentially be because I am using fontInfo: FluentUI_common.FontInfo since the error says that it cannot find type 'FluentUI_common' in scope?

mischreiber
mischreiber reviewed May 2, 2025
View reviewed changes
@veronicasalas
Copy link
Copy Markdown
Contributor Author

veronicasalas commented May 7, 2025

@veronicasalas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@veronicasalas
Copy link
Copy Markdown
Contributor Author

veronicasalas commented May 7, 2025

@microsoft-github-policy-service agree company="Microsoft"

@mischreiber mischreiber enabled auto-merge (squash) May 7, 2025 22:23
@mischreiber mischreiber merged commit bbb9e15 into microsoft:main May 7, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu joannaquu joannaquu left review comments

@mischreiber mischreiber mischreiber approved these changes

@huwilkes huwilkes huwilkes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veronicasalas @mischreiber @joannaquu @huwilkes