MSFNotification can set a closure to run regardless of the source of the disimissal#2144
Merged
cbowdoin merged 4 commits intomicrosoft:mainfrom May 6, 2025
Conversation
…regardless of the cause of the dismiss
mischreiber
reviewed
Apr 30, 2025
Sources/FluentUI_iOS/Components/Notification/FluentNotification.swift
Outdated
Show resolved
Hide resolved
Sources/FluentUI_iOS/Components/Notification/FluentNotification.swift
Outdated
Show resolved
Hide resolved
mischreiber
reviewed
May 1, 2025
Sources/FluentUI_iOS/Components/Notification/FluentNotification.swift
Outdated
Show resolved
Hide resolved
mischreiber
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Added a new onDismiss closure that will be called whenever the Notification View disappears. This allows for consumers to ensure that some action will always be taken whenever the notification is dismissed regardless of what the source of the notification being dismissed is.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Tested with closures in demo app.
Created notificatiosn from both swift and objective c code
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow