[macOS] Add dynamic color support directly to NSColor#2138
Merged
mischreiber merged 2 commits intomicrosoft:mainfrom Mar 7, 2025
Merged
[macOS] Add dynamic color support directly to NSColor#2138mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber merged 2 commits intomicrosoft:mainfrom
Conversation
Saadnajmi
reviewed
Mar 7, 2025
Saadnajmi
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Creates a new extension on
NSColorthat adds dynamic color support, similar to the equivalent methods inUIColor+Extensions.swift.These changes will be important for
FluentThemeintegration, which is almost ready :)New:
NSColorwith explicitlightanddarkvariants.Verification
Verified that the new dynamic colors work as expected:
lightmethod always returns the light value.darkmethod returns either dark if it exists, or light if not.NSAppearanceas expected. This includes redrawing when the system appearance changes.Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow