[macOS] Mark macOS ColorSet and DynamicColor as legacy#2136
Merged
mischreiber merged 2 commits intomicrosoft:mainfrom Mar 5, 2025
Merged
[macOS] Mark macOS ColorSet and DynamicColor as legacy#2136mischreiber merged 2 commits intomicrosoft:mainfrom
ColorSet and DynamicColor as legacy#2136mischreiber merged 2 commits intomicrosoft:mainfrom
Conversation
joannaquu
approved these changes
Mar 4, 2025
lukas-cap
approved these changes
Mar 4, 2025
nodes11
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
As we prepare to move
FluentThemeto macOS, we first need to clean up some upcoming name collisions. The biggest culprit are the little-usedColorSetandDynamicColor, used byAvatarandBadgeView.Once the port is complete, we will remove these classes entirely and replace them with
FluentTheme-compatible equivalents. For now, let's just avert the name collision to ease with porting.Binary change
n/a, only renaming classes.
Verification
Ran full automation locally -- all looks right and renders as expected.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow