Skip to content

[macOS] Mark macOS ColorSet and DynamicColor as legacy#2136

Merged
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:LegacyDynamicColorAndColorSet
Mar 5, 2025
Merged

[macOS] Mark macOS ColorSet and DynamicColor as legacy#2136
mischreiber merged 2 commits intomicrosoft:mainfrom
mischreiber:LegacyDynamicColorAndColorSet

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Mar 4, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

As we prepare to move FluentTheme to macOS, we first need to clean up some upcoming name collisions. The biggest culprit are the little-used ColorSet and DynamicColor, used by Avatar and BadgeView.

Once the port is complete, we will remove these classes entirely and replace them with FluentTheme-compatible equivalents. For now, let's just avert the name collision to ease with porting.

Binary change

n/a, only renaming classes.

Verification

Ran full automation locally -- all looks right and renders as expected.

Visual Verification
Light Dark
Screenshot 2025-03-04 at 1 25 08 PM Screenshot 2025-03-04 at 1 25 02 PM
Screenshot 2025-03-04 at 1 24 43 PM Screenshot 2025-03-04 at 1 24 56 PM

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber added the API break This PR introduces a breaking API change label Mar 4, 2025
@mischreiber mischreiber requested a review from a team as a code owner March 4, 2025 21:26
@mischreiber mischreiber merged commit 5ce543a into microsoft:main Mar 5, 2025
7 checks passed
@mischreiber mischreiber deleted the LegacyDynamicColorAndColorSet branch March 5, 2025 00:47
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API break This PR introduces a breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants