[macOS] Announce DatePickerController changes in VoiceOver#2134
Merged
mischreiber merged 6 commits intomicrosoft:mainfrom Mar 19, 2025
Merged
[macOS] Announce DatePickerController changes in VoiceOver#2134mischreiber merged 6 commits intomicrosoft:mainfrom
DatePickerController changes in VoiceOver#2134mischreiber merged 6 commits intomicrosoft:mainfrom
Conversation
Demos/FluentUIDemo_macOS/FluentUITestViewControllers/TestDatePickerController.swift
Outdated
Show resolved
Hide resolved
Sources/FluentUI_macOS/Components/DatePicker/DatePickerView.swift
Outdated
Show resolved
Hide resolved
brentpe
reviewed
Mar 19, 2025
brentpe
approved these changes
Mar 19, 2025
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") |
Contributor
There was a problem hiding this comment.
minor: Should be preconditionFailure per https://lapcatsoftware.com/articles/fatalError.html. And can also mark func as unavailable?
| self.setAccessibilityRole(.incrementor) | ||
|
|
||
| self.addView(monthYearLabel, in: .center) | ||
| self.addView(leadingButton, in: .leading) |
Contributor
There was a problem hiding this comment.
Should we mark these nested controls as not accessibility elements to match OS pattern of stepper elements not having children?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
NSAccessibilityStepperfor the header, making it possible to read and change the value of the header as one entire element.NSAccessibilityannouncement when the visible month in theDatePickerControllerchanges.TestDatePickerControllerso popover-hosted picker works as expected.Binary change
n/a, no Mac size testing
Verification
Stepper.mov
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow