Skip to content

[macOS] Fix ObjC export of MultilinePillPickerView#2122

Merged
mischreiber merged 8 commits intomicrosoft:mainfrom
mischreiber:MultilinePillPickerView_objc
Jan 29, 2025
Merged

[macOS] Fix ObjC export of MultilinePillPickerView#2122
mischreiber merged 8 commits intomicrosoft:mainfrom
mischreiber:MultilinePillPickerView_objc

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jan 28, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

My previous PR #2121 didn't work in ObjC as expected. Since we don't have a real ObjC demo in macOS yet, this was manually validated to quickly unblock the issue.

(The problem was inheriting from a generic class -- that silently fails to export to Objective-C, even though there's an @objc in the title.)

Binary change

n/a, still can't measure macOS

Verification

Verified MPP component still renders as expected.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner January 28, 2025 19:22
@mischreiber mischreiber enabled auto-merge (squash) January 28, 2025 19:27
@mischreiber mischreiber merged commit e93876b into microsoft:main Jan 29, 2025
@mischreiber mischreiber deleted the MultilinePillPickerView_objc branch January 29, 2025 21:13
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants