Skip to content

Restore build and link of macOS legacy SwiftUI demo app#2120

Merged
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:fixSwiftUIDemoAppMac
Jan 22, 2025
Merged

Restore build and link of macOS legacy SwiftUI demo app#2120
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:fixSwiftUIDemoAppMac

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jan 21, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The SwiftUI demo app for macOS was failing to link the FluentUI library or copy its asset catalog, likely due to the repo refactor from a few months ago. This restores that functionality, making the app usable again.

Binary change

n/a, demo app changes only

Verification

Verified that all demos in the macOS legacy SwiftUI demo app run and display successfully.

Visual Verification DemoApp

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner January 21, 2025 23:21
@mischreiber mischreiber merged commit 72b3036 into microsoft:main Jan 22, 2025
@mischreiber mischreiber deleted the fixSwiftUIDemoAppMac branch January 22, 2025 00:20
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants